From: maxious Date: Sat, 09 Apr 2011 14:15:42 +0000 Subject: Refactor trip/route view X-Git-Url: http://maxious.lambdacomplex.org/git/?p=busui.git&a=commitdiff&h=efeff5c4e4d0097a04cb3156d11261cde47ff132 --- Refactor trip/route view --- --- a/include/db/route-dao.inc.php +++ b/include/db/route-dao.inc.php @@ -40,6 +40,7 @@ } function getRouteNextTrip($routeID) { + global $conn; $query = "select * from routes join trips on trips.route_id = routes.route_id join stop_times on stop_times.trip_id = trips.trip_id where arrival_time > CURRENT_TIME and routes.route_id = '$routeID' order by @@ -52,7 +53,19 @@ } return pg_fetch_assoc($result); } - +function getRouteTrips($routeID) { + global $conn; + $query = "select * from routes join trips on trips.route_id = routes.route_id +join stop_times on stop_times.trip_id = trips.trip_id where routes.route_id = '$routeID' order by +arrival_time "; + debug($query,"database"); + $result = pg_query($conn, $query); + if (!$result) { + databaseError(pg_result_error($result)); + return Array(); + } + return pg_fetch_all($result); + } function getRoutesByDestination($destination = "", $service_period = "") { global $conn; if ($service_period == "") $service_period = service_period(); --- a/include/db/trip-dao.inc.php +++ b/include/db/trip-dao.inc.php @@ -2,7 +2,10 @@ function getTrip($tripID) { global $conn; - $query = "Select * from trips where trip_id = '$tripID' join routes on trips.route_id = routes.route_id LIMIT 1"; + $query = "Select * from trips + join routes on trips.route_id = routes.route_id + where trip_id = '$tripID' + LIMIT 1"; debug($query, "database"); $result = pg_query($conn, $query); if (!$result) { @@ -49,7 +52,7 @@ function getTimeInterpolatedTrip($tripID) { global $conn; - $query = "SELECT stop_times.trip_id,arrival_time,stop_times.stop_id,stop_lat,stop_lon, + $query = "SELECT stop_times.trip_id,arrival_time,stop_times.stop_id,stop_lat,stop_lon,stop_name,stop_code, stop_sequence,service_id,trips.route_id,route_short_name,route_long_name FROM stop_times join trips on trips.trip_id = stop_times.trip_id @@ -129,14 +132,14 @@ $r = pg_fetch_assoc($result); return $r['arrival_time']; } -function viaPointNames($tripid, $stopid) +function viaPointNames($tripid, $stop_sequence = "") { global $conn; $query = "SELECT stop_name FROM stop_times join stops on stops.stop_id = stop_times.stop_id WHERE stop_times.trip_id = '$tripid' -AND stop_sequence > '$stop_sequence' -AND substr(stop_code,1,2) != 'Wj' ORDER BY stop_sequence"; +".($stop_sequence != "" ? "AND stop_sequence > '$stop_sequence'" : ""). +"AND substr(stop_code,1,2) != 'Wj' ORDER BY stop_sequence"; debug($query, "database"); $result = pg_query($conn, $query); if (!$result) { --- a/stop.php +++ b/stop.php @@ -94,8 +94,8 @@ foreach ($trips as $trip) { echo '
  • '; echo '

    ' . $trip['route_short_name'] . " " . $trip['route_long_name'] . "

    "; - //$viaPoints = viaPointNames($trip['trip_id'], $trip['stop_sequence']); - //if ($viaPoints != "") echo '
    Via: ' . $viaPoints . ''; + $viaPoints = viaPointNames($trip['trip_id'], $trip['stop_sequence']); + if ($viaPoints != "") echo '
    Via: ' . $viaPoints . ''; if (sizeof($tripStopNumbers) > 0) { echo '
    Boarding At: '; foreach ($tripStopNumbers[$trip['trip_id']] as $key) { --- a/transitdata.sql +++ /dev/null @@ -1,59 +1,1 @@ --- --- PostgreSQL database dump --- -SET statement_timeout = 0; -SET client_encoding = 'UTF8'; -SET standard_conforming_strings = off; -SET check_function_bodies = false; -SET client_min_messages = warning; -SET escape_string_warning = off; - -SET search_path = public, pg_catalog; - -SET default_tablespace = ''; - -SET default_with_oids = false; - --- --- Name: trips; Type: TABLE; Schema: public; Owner: postgres; Tablespace: --- - -CREATE TABLE trips ( - route_id integer, - trip_id integer NOT NULL, - trip_headsign text, - service_id text -); - - -ALTER TABLE public.trips OWNER TO postgres; - --- --- Data for Name: trips; Type: TABLE DATA; Schema: public; Owner: postgres --- - -COPY trips (route_id, trip_id, trip_headsign, service_id) FROM stdin; -\. - - --- --- Name: trips_pkey; Type: CONSTRAINT; Schema: public; Owner: postgres; Tablespace: --- - -ALTER TABLE ONLY trips - ADD CONSTRAINT trips_pkey PRIMARY KEY (trip_id); - - --- --- Name: routetrips; Type: INDEX; Schema: public; Owner: postgres; Tablespace: --- - -CREATE INDEX routetrips ON trips USING btree (route_id); - - --- --- PostgreSQL database dump complete --- - - --- a/trip.php +++ b/trip.php @@ -3,95 +3,81 @@ $tripid = filter_var($_REQUEST['tripid'], FILTER_SANITIZE_NUMBER_INT); $stopid = filter_var($_REQUEST['stopid'], FILTER_SANITIZE_NUMBER_INT); $routeid = filter_var($_REQUEST['routeid'], FILTER_SANITIZE_NUMBER_INT); + $routetrips = Array(); + if ($_REQUEST['routeid'] && !$_REQUEST['tripid']) { - $tripid = 0; - $url = $APIurl . "/json/routetrips?route_id=" . $routeid; - $routetrips = json_decode(getPage($url)); - foreach ($routetrips as $trip) { - if ($trip[2] > midnight_seconds()) { - $tripid = $trip[1]; - break; - } - } - if ($tripid == 0) $tripid = $routetrips[0][1]; + $trip = getRouteNextTrip($routeid); + $tripid = $trip['trip_id']; +} else { + $trip = getTrip($tripid); + $routeid = $trip["route_id"]; } -$url = $APIurl . "/json/triprows?trip=" . $tripid; -$trips = array_flatten(json_decode(getPage($url))); -if (sizeof($routetrips) == 0) { - $routeid = $trips[1]->route_id; - $url = $APIurl . "/json/routetrips?route_id=" . $trips[1]->route_id; - $routetrips = json_decode(getPage($url)); -} -include_header("Stops on " . $trips[1]->route_short_name . ' ' . $trips[1]->route_long_name, "trip"); -trackEvent("Route/Trip View","View Route", $trips[1]->route_short_name . ' ' . $trips[1]->route_long_name, $trips[1]->route_id); -$url = $APIurl . "/json/tripstoptimes?trip=" . $tripid; -$json = json_decode(getPage($url)); -$stops = $json[0]; -$times = $json[1]; -$viaPoints = Array(); -foreach ($stops as $stop) { - if (!startsWith($stop[5], "Wj")) { - $viaPoints[] = $stop[1]; - } -} -echo '

    Via:

    ' . implode(", ", $viaPoints) . '

    '; + +$routetrips = getRouteTrips($routeid); + +include_header("Stops on " . $trip['route_short_name'] . ' ' . $trip['route_long_name'], "trip"); +trackEvent("Route/Trip View","View Route", $trip['route_short_name'] . ' ' . $trip['route_long_name'], $routeid); + + +echo '

    Via:

    ' . viaPointNames($tripid) . '

    '; echo '

    Other Trips:

    '; -foreach ($routetrips as $othertrip) { - echo '    ' . midnight_seconds_to_time($othertrip[0]) . ' '; +foreach (getRouteTrips($routeid) as $othertrip) { + echo '' . str_replace(" ",":00",str_replace(":00"," ",$othertrip['arrival_time'])). ' '; } flush(); @ob_flush(); echo '

    Other directions/timing periods:

    '; -$url = $APIurl . "/json/routesearch?routeshortname=" . rawurlencode($trips[1]->route_short_name); -$json = json_decode(getPage($url)); -foreach ($json as $row) { - if ($row[0] != $routeid) echo '' . $row[2] . ' (' . ucwords($row[3]) . ') '; +foreach (getRoutesByNumber($trip['route_short_name']) as $row) { + if ($row['route_id'] != $routeid) echo '' . $row['route_long_name'] . ' (' . ucwords($row['service_id']) . ') '; } flush(); @ob_flush(); echo '