Fix css issues
Place time/period/location adjuster on many views
Sanitize more user input
--- a/busui/common.inc.php
+++ b/busui/common.inc.php
@@ -1,14 +1,33 @@
<?php
date_default_timezone_set('Australia/ACT');
$APIurl = "http://localhost:8765";
-error_reporting(E_ALL ^ E_NOTICE);
+$cloudmadeAPIkey="daa03470bb8740298d4b10e3f03d63e6";
+$googleMapsAPIkey="ABQIAAAA95XYXN0cki3Yj_Sb71CFvBTPaLd08ONybQDjcH_VdYtHHLgZvRTw2INzI_m17_IoOUqH3RNNmlTk1Q";
+$otpAPIurl = 'http://10.1.0.243:5080/opentripplanner-api-webapp/';
+if (isDebug()) error_reporting(E_ALL ^ E_NOTICE);
+
+// SELECT array_to_string(array(SELECT REPLACE(name_2006, ',', '\,') as name FROM suburbs order by name), ',')
+$suburbs = explode(",","Acton,Ainslie,Amaroo,Aranda,Banks,Barton,Belconnen,Bonner,Bonython,Braddon,Bruce,Calwell,Campbell,Chapman,Charnwood,Chifley,Chisholm,City,Conder,Cook,Curtin,Deakin,Dickson,Downer,Duffy,Dunlop,Evatt,Fadden,Farrer,Fisher,Florey,Flynn,Forrest,Franklin,Fraser,Fyshwick,Garran,Gilmore,Giralang,Gordon,Gowrie,Greenway,Griffith,Gungahlin,Hackett,Hall,Harrison,Hawker,Higgins,Holder,Holt,Hughes,Hume,Isaacs,Isabella Plains,Kaleen,Kambah,Kingston,Latham,Lawson,Lyneham,Lyons,Macarthur,Macgregor,Macquarie,Mawson,McKellar,Melba,Mitchell,Monash,Narrabundah,Ngunnawal,Nicholls,Oaks Estate,O'Connor,O'Malley,Oxley,Page,Palmerston,Parkes,Pearce,Phillip,Pialligo,Red Hill,Reid,Richardson,Rivett,Russell,Scullin,Spence,Stirling,Symonston,Tharwa,Theodore,Torrens,Turner,Wanniassa,Waramanga,Watson,Weetangera,Weston,Yarralumla");
+
// you have to open the session to be able to modify or remove it
- session_start();
-
-
+session_start();
+ if (isset($_REQUEST['service_period'])) $_SESSION['service_period'] = filter_var($_REQUEST['service_period'],FILTER_SANITIZE_STRING);
+ if (isset($_REQUEST['time'])) $_SESSION['time'] = filter_var($_REQUEST['time'],FILTER_SANITIZE_STRING);
+ if (isset($_REQUEST['geolocate'])) {
+ $contents = geocode(var_filter($_REQUEST['geolocate'],FILTER_SANITIZE_URL),true);
+ if (isset($contents[0]->centroid)) {
+ $session['lat'] = $contents[0]->centroid->coordinates[0];
+ $session['lon'] = $contents[0]->centroid->coordinates[1];
+ }
+ else {
+ $session['lat'] = "";
+ $session['lon'] = "";
+ }
+ }
+//print_r ($_SESSION);
function isDebug()
{
- return $_SERVER['SERVER_NAME'] == "localhost" || $_SERVER['SERVER_NAME'] == "127.0.0.1" || !$_SERVER['SERVER_NAME'];
+ return $_SERVER['SERVER_NAME'] == "10.0.1.154" || $_SERVER['SERVER_NAME'] == "localhost" || $_SERVER['SERVER_NAME'] == "127.0.0.1" || !$_SERVER['SERVER_NAME'];
}
function debug($msg) {
@@ -19,10 +38,6 @@
}
function include_header($pageTitle, $opendiv = true, $geolocate = false) {
- // this starts the session
- session_start();
-
- // if (isDebug()) // set php error level high
echo '
<!DOCTYPE html>
<html>
@@ -47,8 +62,16 @@
<script src="js/jquery.ui.datepicker.mobile.js"></script>
<style type="text/css">
.ui-navbar {
- padding-bottom: 18px;
width: 100%;
+ }
+ .ui-btn-inner {
+ white-space: normal !important;
+ }
+ .ui-li-heading {
+ white-space: normal !important;
+ }
+ .ui-listview-filter {
+ margin: 0 !important;
}
</style>
<meta name="apple-mobile-web-app-capable" content="yes" />
@@ -58,35 +81,12 @@
if ($geolocate) {
echo "<script>
-function setCookie(c_name,value,expiredays)
-{
-var exdate=new Date();
-exdate.setDate(exdate.getDate()+expiredays);
-document.cookie=c_name+ \"=\" +escape(value)+
-((expiredays==null) ? \"\" : \";expires=\"+exdate.toUTCString());
-}
-
-function getCookie(c_name)
-{
-if (document.cookie.length>0)
- {
- c_start=document.cookie.indexOf(c_name + \"=\");
- if (c_start!=-1)
- {
- c_start=c_start + c_name.length+1;
- c_end=document.cookie.indexOf(\";\",c_start);
- if (c_end==-1) c_end=document.cookie.length;
- return unescape(document.cookie.substring(c_start,c_end));
- }
- }
-return \"\";
-}
-
function success(position) {
$('#geolocate').val(position.coords.latitude+','+position.coords.longitude);
-setCookie('geolocate',position.coords.latitude+','+position.coords.longitude,1);
-}
-
+// setCookie('geolocate',position.coords.latitude+','+position.coords.longitude,1);
+$('#here').click(function(event) { $('#geolocate').val(doAJAXrequestForGeolocSessionHere()); return false;});
+$('#here').show();
+}
function error(msg) {
console.log(msg);
}
@@ -100,17 +100,25 @@
echo '</head>
<body>
';
-if ($opendiv) echo '<div data-role="page">
+if ($opendiv) {
+ echo '<div data-role="page">
<div data-role="header">
<h1>'.$pageTitle.'</h1>
</div><!-- /header -->
<div data-role="content"> ';
}
+}
function include_footer()
{
- echo '</div>';
+ if ($geolocate && isset($_SESSION['lat'])) {
+ echo "<script>
+ $('#here').click(function(event) { $('#geolocate').val(doAJAXrequestForGeolocSessionHere()); return false;});
+$('#here').show();
+</script>";
+ }
+ echo '</div>';
}
$service_periods = Array ('sunday','saturday','weekday');
@@ -139,7 +147,7 @@
{
// from http://www.perturb.org/display/Perlfunc__Seconds_Since_Midnight.html
if (isset($_SESSION['time'])) {
- $time = mkdate($_SESSION['time']);
+ $time = strtotime($_SESSION['time']);
return (date("G",$time) * 3600) + (date("i",$time) * 60) + date("s",$time);
}
return (date("G") * 3600) + (date("i") * 60) + date("s");
@@ -156,6 +164,7 @@
}
function getPage($url)
{
+ debug($url);
$ch = curl_init($url);
curl_setopt( $ch, CURLOPT_RETURNTRANSFER, 1 );
curl_setopt( $ch, CURLOPT_HEADER, 0 );
@@ -219,8 +228,11 @@
}
$center = $totalLat/sizeof($mapPoints).",".$totalLon/sizeof($mapPoints);
}
-
- return '<img src="staticmaplite/staticmap.php?center='.$center.'&zoom='.$zoom.'&size='.$width.'x'.$height.'&maptype=mapnik&markers='.$markers.'" width='.$width.' height='.$height.'>';
+ $output = "";
+ $output .= '<div data-role="collapsible" data-collapsed="true"><h3>Open Map...</h3>';
+ $output .= '<center><img src="staticmaplite/staticmap.php?center='.$center.'&zoom='.$zoom.'&size='.$width.'x'.$height.'&maptype=mapnik&markers='.$markers.'" width='.$width.' height='.$height.'></center>';
+ $output .= '</div>';
+ return $output;
}
function distance($lat1, $lng1, $lat2, $lng2)
@@ -326,7 +338,8 @@
}
function geocode($query, $giveOptions) {
- $url = "http://geocoding.cloudmade.com/daa03470bb8740298d4b10e3f03d63e6/geocoding/v2/find.js?query=".$query."&bbox=-35.5,149.00,-35.15,149.1930&return_location=true&bbox_only=true";
+ global $cloudmadeAPIkey;
+ $url = "http://geocoding.cloudmade.com/$cloudmadeAPIkey/geocoding/v2/find.js?query=".$query."&bbox=-35.5,149.00,-35.15,149.1930&return_location=true&bbox_only=true";
$contents = json_decode(getPage($url));
if ($giveOptions) return $contents->features;
elseif (isset($contents->features[0]->centroid)) return $contents->features[0]->centroid->coordinates[0].",".$contents->features[0]->centroid->coordinates[1];
@@ -334,7 +347,8 @@
}
function reverseGeocode($lat,$lng) {
- $url = "http://geocoding.cloudmade.com/daa03470bb8740298d4b10e3f03d63e6/geocoding/v2/find.js?around=".$lat.",".$lng."&distance=closest&object_type=road";
+ global $cloudmadeAPIkey;
+ $url = "http://geocoding.cloudmade.com/$cloudmadeAPIkey/geocoding/v2/find.js?around=".$lat.",".$lng."&distance=closest&object_type=road";
$contents = json_decode(getPage($url));
return $contents->features[0]->properties->name;
}
@@ -351,6 +365,76 @@
function bracketsMeanNewLine($input) {
return str_replace(")","</small>",str_replace("(","<br><small>",$input));
}
+
+function viaPoints($tripid,$stopid, $timingPointsOnly = false) {
+ global $APIurl;
+ $url = $APIurl."/json/tripstoptimes?trip=".$tripid;
+
+$json = json_decode(getPage($url));
+debug(print_r($json,true));
+$stops = $json[0];
+$times = $json[1];
+$foundStop = false;
+$viaPoints = Array();
+foreach ($stops as $key => $row)
+{
+ if ($foundStop) {
+ if (!$timingPointsOnly || !startsWith($row[5],"Wj") ) {
+ $viaPoints[] = Array("id" => $row[0], "name" => $row[1], "time" => $times[$key]);
+ }
+ } else {
+ if ($row[0] == $stopid) $foundStop = true;
+ }
+}
+ return $viaPoints;
+}
+
+function viaPointNames($tripid,$stopid) {
+ $points = viaPoints($tripid,$stopid,true);
+ $pointNames = Array();
+ foreach ($points as $point) {
+ $pointNames[] = $point['name'];
+ }
+ return implode(", ",$pointNames);
+}
+
+function timePlaceSettings($geolocate = false) {
+ global $service_periods;
+ $geoerror = false;
+ if ($geolocate == true) {
+ $geoerror = !isset($_SESSION['lat']) || !isset($_SESSION['lat'])
+ || $_SESSION['lat'] == "" || $_SESSION['lon'] == "";
+ }
+ if ($geoerror) {
+ echo '<div class="error">Sorry, but your location could not currently be detected.
+ Please allow location permission, wait for your location to be detected,
+ or enter an address/co-ordinates in the box below.</div>';
+ }
+ echo '<div data-role="collapsible" data-collapsed="'.!$geoerror.'">
+ <h3>Change Time/Place...</h3>
+ <form action="" method="post">
+ <div class="ui-body">
+ <div data-role="fieldcontain">
+ <label for="geolocate"> Current Location: </label>
+ <input type="text" id="geolocate" name="geolocate" value="Enter co-ordinates or address here"/> <a href="#" style="display:none" name="here" id="here"/>Here?</a>
+ </div>
+ <div data-role="fieldcontain">
+ <label for="time"> Time: </label>
+ <input type="time" name="time" id="time" value="'. ($_SESSION['time'] ? $_SESSION['time'] : date("H:m")).'"/> <a href="#" name="currentTime" id="currentTime"/>Current Time?</a>
+ </div>
+ <div data-role="fieldcontain">
+ <label for="service_period"> Service Period: </label>
+ <select name="service_period">';
+
+ foreach ($service_periods as $service_period) {
+ echo "<option value=\"$service_period\"".(service_period() === $service_period ? "SELECTED" : "").'>'.ucwords($service_period).'</option>';
+ }
+ echo '</select>
+ <a href="#" style="display:none" name="currentPeriod" id="currentPeriod"/>Current Period?</a>
+ </div>
+
+ <input type="submit" value="Update"/>
+ </form>
+ </div></div>';
+}
?>
-
-
Binary files /dev/null and b/busui/css/images/01-refresh.png differ
Binary files /dev/null and b/busui/css/images/02-redo.png differ
Binary files /dev/null and b/busui/css/images/06-magnify.png differ
Binary files /dev/null and b/busui/css/images/07-map-marker.png differ
Binary files /dev/null and b/busui/css/images/101-gameplan.png differ
Binary files /dev/null and b/busui/css/images/102-walk.png differ
Binary files /dev/null and b/busui/css/images/103-map.png differ
Binary files /dev/null and b/busui/css/images/113-navigation.png differ
Binary files /dev/null and b/busui/css/images/121-landscape.png differ
Binary files /dev/null and b/busui/css/images/13-target.png differ
Binary files /dev/null and b/busui/css/images/139-flags.png differ
Binary files /dev/null and b/busui/css/images/145-persondot.png differ
Binary files /dev/null and b/busui/css/images/184-warning.png differ
Binary files /dev/null and b/busui/css/images/193-location-arrow.png differ
Binary files /dev/null and b/busui/css/images/28-star.png differ
Binary files /dev/null and b/busui/css/images/53-house.png differ
Binary files /dev/null and b/busui/css/images/55-network.png differ
Binary files /dev/null and b/busui/css/images/57-download.png differ
Binary files /dev/null and b/busui/css/images/58-bookmark.png differ
Binary files /dev/null and b/busui/css/images/59-flag.png differ
Binary files /dev/null and b/busui/css/images/60-signpost.png differ
Binary files /dev/null and b/busui/css/images/73-radar.png differ
Binary files /dev/null and b/busui/css/images/74-location.png differ
Binary files /dev/null and b/busui/css/images/83-calendar.png differ
Binary files a/busui/images/01-refresh.png and /dev/null differ
Binary files a/busui/images/02-redo.png and /dev/null differ
Binary files a/busui/images/06-magnify.png and /dev/null differ
Binary files a/busui/images/07-map-marker.png and /dev/null differ
Binary files a/busui/images/101-gameplan.png and /dev/null differ
Binary files a/busui/images/102-walk.png and /dev/null differ
Binary files a/busui/images/103-map.png and /dev/null differ
Binary files a/busui/images/113-navigation.png and /dev/null differ
Binary files a/busui/images/121-landscape.png and /dev/null differ
Binary files a/busui/images/13-target.png and /dev/null differ
Binary files a/busui/images/139-flags.png and /dev/null differ
Binary files a/busui/images/145-persondot.png and /dev/null differ
Binary files a/busui/images/184-warning.png and /dev/null differ
Binary files a/busui/images/193-location-arrow.png and /dev/null differ
Binary files a/busui/images/28-star.png and /dev/null differ
Binary files a/busui/images/53-house.png and /dev/null differ
Binary files a/busui/images/55-network.png and /dev/null differ
Binary files a/busui/images/57-download.png and /dev/null differ
Binary files a/busui/images/58-bookmark.png and /dev/null differ
Binary files a/busui/images/59-flag.png and /dev/null differ
Binary files a/busui/images/60-signpost.png and /dev/null differ
Binary files a/busui/images/73-radar.png and /dev/null differ
Binary files a/busui/images/74-location.png and /dev/null differ
Binary files a/busui/images/83-calendar.png and /dev/null differ
--- a/busui/index.php
+++ b/busui/index.php
@@ -1,62 +1,28 @@
<?php
include('common.inc.php');
- // remove all the variable in the session
- session_unset();
-
- //destroy the session
- session_destroy();
- if (isset($_REQUEST['service_period'])) $_SESSION['service_period'] = $_REQUEST['service_period'];
- if (isset($_REQUEST['time'])) $_SESSION['time'] = $_REQUEST['time'];
- // todo take in cellids and crossreference with http://realtimeblog.free.fr/latest/cellular/processed/sqlite/505_sqlite_zones.zip to estimate location
include_header("bus.lambdacomplex.org",false, true)
?>
<div data-role="page">
<div data-role="content">
<div id="jqm-homeheader">
- <center><h3 id="jqm-logo"><img src="apple-touch-icon.png" alt="logo" width="64" height="64" /><br>
- busness time</h3></center>
+ <center><h3>busness time</h3><br><small>Canberra Bus Timetables and Trip Planner</small></center>
</div>
<a href="tripPlanner.php" data-role="button">Launch Trip Planner...</a>
<ul data-role="listview" data-inset="true" data-theme="c" data-dividertheme="b">
<li data-role="list-divider">Timetables - Stops</li>
<li><a href="stopList.php">Major (Timing Point) Stops</a></li>
<li><a href="stopList.php">All Stops</a></li>
- <li><a href="stopList.php?nearbyfavs=yes">Nearby/Favourite Stops</a></li>
+ <li><a href="stopList.php?suburbs=yes">Stops By Suburb</a></li>
+ <li><a class="nearby" href="stopList.php?nearby=yes">Nearby Stops</a></li>
</ul>
<ul data-role="listview" data-inset="true" data-theme="c" data-dividertheme="b">
<li data-role="list-divider">Timetables - Routes</li>
<li><a href="routeList.php">Routes By Final Destination</a></li>
<li><a href="routeList.php?bynumber=yes">Routes By Number</a></li>
- <li><a href="routeList.php?nearbyfavs=yes">Nearby/Favourites Routes</a></li>
+ <li><a class="nearby" href="routeList.php?nearby=yes">Nearby Routes</a></li>
</ul>
- <div class="ui-body ui-body-c">
- <h3>Time/Place Settings</h3>
- <div data-role="fieldcontain">
- <label for="geolocate"> Current Location: </label>
- <input type="text" id="geolocate" name="geolocate"/> <a href="#" style="display:none" name="here" id="here"/>Here?</a>
- </div>
- <div data-role="fieldcontain">
- <label for="time"> Time: </label>
- <input type="time" value="<?php echo date("H:m"); ?>"/> <a href="#" style="display:none" name="currentTime" id="currentTime"/>Current Time?</a>
- </div>
- <div data-role="fieldcontain">
- <label for="service_period"> Service Period: </label>
- <select name="service_period">
- <?php
- foreach ($service_periods as $service_period) {
- echo "<option value=\"$service_period\"".(service_period() === $service_period ? "SELECTED" : "").'>'.ucwords($service_period).'</option>';
- }?>
- </select>
- <a href="#" style="display:none" name="currentPeriod" id="currentPeriod"/>Current Period?</a>
- </div>
-
- <input type="submit" value="Update"/>
- </div>
- <script>
-$('#here').click(function(event) { $('#geolocate').val(getCookie('geolocate')); return false;});
-$('#here').show();
- </script>
- </div>
+<?php echo timePlaceSettings();?>
+
</div>
</body>
</html>
--- a/busui/js/jquery.ui.datepicker.mobile.js
+++ b/busui/js/jquery.ui.datepicker.mobile.js
@@ -47,9 +47,12 @@
};
//bind to pagecreate to automatically enhance date inputs
- $( ".ui-page" ).live( "pagecreate", function(){
+ $( ".ui-page" ).live( "pagecreate", function(){
$( "input[type='date'], input[data-type='date']" ).each(function(){
+ if ($(this).hasClass("hasDatepicker") == false) {
$(this).after( $( "<div />" ).datepicker({ altField: "#" + $(this).attr( "id" ), showOtherMonths: true }) );
- });
- });
+ $(this).addClass("hasDatepicker");
+ }
+ });
+ });
})( jQuery );
--- a/busui/routeList.php
+++ b/busui/routeList.php
@@ -6,7 +6,8 @@
<ul>
<li><a href="routeList.php">By Final Destination...</a></li>
<li><a href="routeList.php?bynumber=yes">By Number... </a></li>
- <!--<li><a href="routeList.php?bysuburb=yes">By Suburb... </a></li>-->
+ <li><a href="routeList.php?bysuburb=yes">By Suburb... </a></li>
+ <li><a href="routeList.php?nearby=yes">Nearby... </a></li>
</ul>
</div>
';
--- a/busui/schedule_viewer.py
+++ b/busui/schedule_viewer.py
@@ -88,8 +88,11 @@
def StopToTuple(stop):
"""Return tuple as expected by javascript function addStopMarkerFromList"""
return (stop.stop_id, stop.stop_name, float(stop.stop_lat),
- float(stop.stop_lon), stop.location_type)
-
+ float(stop.stop_lon), stop.location_type, stop.stop_code)
+def StopZoneToTuple(stop):
+ """Return tuple as expected by javascript function addStopMarkerFromList"""
+ return (stop.stop_id, stop.stop_name, float(stop.stop_lat),
+ float(stop.stop_lon), stop.location_type, stop.stop_code, stop.zone_id)
class ScheduleRequestHandler(BaseHTTPServer.BaseHTTPRequestHandler):
def do_GET(self):
@@ -301,11 +304,11 @@
except KeyError:
# if a non-existent trip is searched for, the return nothing
return
- time_stops = trip.GetTimeStops()
+ time_stops = trip.GetTimeInterpolatedStops()
stops = []
times = []
- for arr,dep,stop in time_stops:
- stops.append(StopToTuple(stop))
+ for arr,ts,is_timingpoint in time_stops:
+ stops.append(StopToTuple(ts.stop))
times.append(arr)
return [stops, times]
@@ -366,7 +369,34 @@
query = params.get('q', None).lower()
matches = []
for s in schedule.GetStopList():
- if s.stop_id.lower().find(query) != -1 or s.stop_name.lower().find(query) != -1:
+ if s.stop_name.lower().find(query) != -1 or s.stop_code.lower().find(query) != -1:
+ matches.append(StopToTuple(s))
+ return matches
+
+ def handle_json_GET_stopnamesearch(self, params):
+ schedule = self.server.schedule
+ query = params.get('q&